qqchang2nd commented on issue #12251: URL: https://github.com/apache/iceberg/issues/12251#issuecomment-2667390528
I understand your concern about the potential for increased parameterization and the implications it may have. However, I believe the changes I've made are quite generalizable and beneficial. The modification introduces an interface that allows for passing properties while still preserving the original usage method. The primary issue with Iceberg's current implementation is that HadoopTables effectively hides the ability to pass properties to HadoopFileIO. This limitation restricts its flexibility. By enabling the ability to pass properties to HadoopTables, we can enhance its functionality without compromising the simplicity of the original API. This change not only addresses our specific use case but also opens up possibilities for other users who may benefit from similar optimizations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org