dttung2905 commented on code in PR #306:
URL: https://github.com/apache/iceberg-go/pull/306#discussion_r1960712467
##########
catalog/sql/sql.go:
##########
@@ -524,9 +525,14 @@ func (c *Catalog) DropNamespace(ctx context.Context,
namespace table.Identifier)
return fmt.Errorf("%w: %s", catalog.ErrNoSuchNamespace,
nsToDelete)
}
- tbls, err := c.ListTables(ctx, namespace)
- if err != nil {
- return err
+ tbls := make([]table.Identifier, 0)
+ iter := c.ListTables(ctx, namespace)
+
+ for tbl, err := range iter {
Review Comment:
Nice catch. Thank you for pointing it out :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
