rdblue commented on code in PR #12139:
URL: https://github.com/apache/iceberg/pull/12139#discussion_r1960605176
##########
core/src/test/java/org/apache/iceberg/variants/VariantTestUtil.java:
##########
@@ -27,10 +29,55 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
public class VariantTestUtil {
private VariantTestUtil() {}
+ public static void assertEqual(VariantMetadata expected, VariantMetadata
actual) {
+ assertThat(actual).isNotNull();
+ assertThat(expected).isNotNull();
+ assertThat(actual.dictionarySize())
+ .as("Dictionary size should match")
+ .isEqualTo(expected.dictionarySize());
+
+ for (int i = 0; i < expected.dictionarySize(); i += 1) {
+ assertThat(actual.get(i)).isEqualTo(expected.get(i));
Review Comment:
The mapping from ID to string must match. We don't really care if the
`sorted` bit is set or not, but the mapping must be identical or else the data
is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
