Fokko commented on code in PR #12302:
URL: https://github.com/apache/iceberg/pull/12302#discussion_r1959893949
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -694,7 +698,10 @@ private static Literal<?> castDefault(Literal<?>
defaultValue, Type type) {
throw new IllegalArgumentException(
String.format("Invalid default value for %s: %s (must be null)",
type, defaultValue));
} else if (defaultValue != null) {
- return defaultValue.to(type);
+ Literal<?> typedDefault = defaultValue.to(type);
Review Comment:
Thinking of it, would a `NoneLiteral` make sense 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
