ismailsimsek commented on PR #11936: URL: https://github.com/apache/iceberg/pull/11936#issuecomment-2665414155
> I did a pass about `LICENSE`/`NOTICE`. > > First, in `kafka-connect-transforms`, I see use of `debezium` package, but for specific code (not code copied from debezium), so it's OK. > > As `kafka-connect-transforms` is used in `kafka-connect-runtime` distributions, I did a pass on the transitive dependencies. Here's what I see in the PR: > > 1. The versions in `LICENSE` doesn't match the one in the distributions (I suggest to do a rebase to fix that) > > 2. `bson` should be in `LICENSE`. As bson comes from https://github.com/mongodb/mongo-java-driver and there's no `NOTICE` there, no need to update `NOTICE` in the distributions. That should be in this PR. > > 3. `detector-resources-support` (from Google Opentelemetry) and `exporter-metrics` (from Google Opentelemetry) are not in `LICENSE`. I will check that (on `main`) as I think I fixed it already. > > > So, @ismailsimsek specifically to this PR, `bson` should be added in `LICENSE`. If you want I can create a commit in this PR for that. Thanks for the review, @jbonofre, I appreciate your feedback. yep its ok for me, feel free to commit it directly to the PR, otherwise I can incorporate them soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
