arnaudbriche commented on code in PR #307:
URL: https://github.com/apache/iceberg-go/pull/307#discussion_r1959518433
##########
manifest.go:
##########
@@ -292,10 +307,15 @@ func (b *ManifestV2Builder) KeyMetadata(km []byte)
*ManifestV2Builder {
// a pointer to the constructed manifest file. Further calls to the modifier
// methods after calling build would modify the constructed ManifestFile.
func (b *ManifestV2Builder) Build() ManifestFile {
+ if b.m.partitionType == nil {
+ b.m.partitionType = UnpartitionedSpec.PartitionType(nil)
+ }
+
return b.m
}
type manifestFileV2 struct {
+ partitionType *StructType
Review Comment:
Not sure if it belongs to `FieldSummary`.
We also need to be able to do `Avro` -> `Iceberg` schema conversion to
populate the field on read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
