ajantha-bhat commented on code in PR #12137:
URL: https://github.com/apache/iceberg/pull/12137#discussion_r1959224967
##########
core/src/test/java/org/apache/iceberg/TestPartitionStatsUtil.java:
##########
@@ -370,16 +371,167 @@ public void testPartitionStatsWithSchemaEvolution()
throws Exception {
snapshot2.snapshotId()));
}
- private static PartitionData partitionData(Types.StructType partitionType,
String c2, String c3) {
- PartitionData partitionData = new PartitionData(partitionType);
- partitionData.set(0, c2);
- partitionData.set(1, c3);
- return partitionData;
+ @org.junit.Test
Review Comment:
I see,
> PartitionMap is initialized with individual partition specs [], but the
supplied key is a unified tuple
I assumed partitionMap will use the key supplied. Now I see that it is based
on the individual spec
https://github.com/apache/iceberg/blob/bcbbd0344623ffea5b092e2de5debb0bc12892a1/core/src/main/java/org/apache/iceberg/util/PartitionMap.java#L181
Since, we don't combine stats for different spec id, your solution works.
Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
