dramaticlly commented on code in PR #11719:
URL: https://github.com/apache/iceberg/pull/11719#discussion_r1958778016


##########
core/src/main/java/org/apache/iceberg/FilesTable.java:
##########
@@ -51,6 +52,20 @@ public static class FilesTableScan extends 
BaseFilesTableScan {
       super(table, schema, MetadataTableType.FILES, context);
     }
 
+    @Override
+    public TableScan useRef(String name) {

Review Comment:
   I think in order to support other metadata tables which also have different 
schema than its base table schema, we might just pull this up from 
FilesTableScan to BaseMetadataTableScan instead. So it will works with 
`.partitions` and `.entries` etc. Also I think BaseAllMetadataTableScan 
overrides this useRef method as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to