stevenzwu commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r1958712529


##########
format/view-spec.md:
##########
@@ -160,6 +179,56 @@ Each entry in `version-log` is a struct with the following 
fields:
 | _required_  | `timestamp-ms` | Timestamp when the view's 
`current-version-id` was updated (ms from epoch) |
 | _required_  | `version-id`   | ID that `current-version-id` was set to |
 
+#### Table Identifier
+
+The table identifier holds a reference, containing a namespace and a name, of 
a table or view in the catalog.
+
+| Requirement | Field name     | Description |
+|-------------|----------------|-------------|
+| _optional_  | `catalog`      | A string specifying the name of the catalog. 
If set to `null`, the catalog is the same as the view's catalog |
+| _required_  | `namespace`    | A list of namespace levels |
+| _required_  | `name`         | A string specifying the name of the 
table/view |
+
+### Materialized View Metadata stored as part of the Table Metadata
+
+A property "refresh-state" is set on the table [snapshot 
summary](https://iceberg.apache.org/spec/#snapshots) to determine the freshness 
of the precomputed data of the storage table.

Review Comment:
   maybe add a clarifying sentence before the `refresh-state` sentence. e.g.
   ```
   This section describes additional metadata for storage table that are 
required for materialized views.
   ```
   
   I am also wondering if this should be added to the `Table spec`. we can add 
a link from the MV spec page here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to