alessandro-nori commented on code in PR #1629: URL: https://github.com/apache/iceberg-python/pull/1629#discussion_r1958292666
########## tests/catalog/test_base.py: ########## @@ -312,7 +312,7 @@ def test_rename_table(catalog: InMemoryCatalog) -> None: assert table._identifier == Catalog.identifier_to_tuple(new_table) # And - assert ("new", "namespace") in catalog.list_namespaces() + assert ("new",) in catalog.list_namespaces() Review Comment: good point! I'll change the assertion from using `list_namespaces()` to `_namespace_exists()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org