omerhadari commented on PR #945: URL: https://github.com/apache/iceberg-rust/pull/945#issuecomment-2662366687
@liurenjie1024 @Fokko regardless of whether or not turning `TO_TIMESTAMP/DATE` into casts makes sense or should be done as a simplification in DataFusion, an important part in this PR is fixing the wrong handling of `CAST(<datetime_str> AS DATE)` expressions, which can cause incorrect query results. Would you like me to extract this part only as a separate PR so that it can be reviewed on its own? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
