dramaticlly commented on PR #12115: URL: https://github.com/apache/iceberg/pull/12115#issuecomment-2662241789
> I think it almost looks ready, I just had one last comment, sorry about not putting it correctly before ! > > I think when I looked last night at for [#12115 (comment)](https://github.com/apache/iceberg/pull/12115#discussion_r1957073932) , my thought was just to unify the two formats for lists, as you had both > > ``` > // newline after the title > * Full Rewrite > > This is a full rewrite > > * Incremetntal Rewrite > > This is an incremental rewrite > ``` > > and > > ``` > // no newline after the title > * Source Path: The original path... > * Target Path: The path with... > ``` > > Sorry I did not consider carefully which one last night, and I think I end up slightly suggesting the former for both. But now after reading the rest of the doc , there is a precedent for the latter. The former may also be a bit confusing as the description is not indented and looks like a first level paragraph. Can we change both lists to be like the latter? (ie, remove the newline, and put the text on the exact same line as the sub-title, putting the colon back between them) > > ``` > * Full Rewrite: A full rewrite... > * Incremental Rewrite: An incremental rewrite... > ``` thank you @szehon-ho , updated as suggested. Appreciate your detailed walk though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
