kevinjqliu commented on code in PR #1429:
URL: https://github.com/apache/iceberg-python/pull/1429#discussion_r1957464703
##########
pyiceberg/catalog/__init__.py:
##########
@@ -945,8 +956,8 @@ def _get_default_warehouse_location(self, database_name:
str, table_name: str) -
raise ValueError("No default path is set, please specify a location
when creating a table")
@staticmethod
- def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path:
str) -> None:
- ToOutputFile.table_metadata(metadata, io.new_output(metadata_path))
+ def _write_metadata(metadata: TableMetadata, io: FileIO, metadata_path:
str, overwrite: bool = False) -> None:
+ ToOutputFile.table_metadata(metadata, io.new_output(metadata_path),
overwrite=overwrite)
Review Comment:
👍 default is False
https://github.com/apache/iceberg-python/blob/300b8405a0fe7d0111321e5644d704026af9266b/pyiceberg/serializers.py#L123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
