kevinjqliu commented on code in PR #1665:
URL: https://github.com/apache/iceberg-python/pull/1665#discussion_r1957222927
##########
pyiceberg/table/__init__.py:
##########
@@ -1148,6 +1148,15 @@ def upsert(
"""
from pyiceberg.table import upsert_util
+ if join_cols is None:
Review Comment:
👍 we should also update the docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
