gaborkaszab commented on PR #11837: URL: https://github.com/apache/iceberg/pull/11837#issuecomment-2658767328
Thanks for taking a look @pvary, @amogh-jahagirdar and @steveloughran ! I'll be offline for a couple of days but will take a deeper look after that. Another thing we discussed with Peter apart from the comments is that the current PR abuses the concept of a `Consumer<String>` because we now try use it as a kind of `Consumer<Iterable<String>>`. The thing that makes this a bit complicated is that the `deleteFunc` is pluggable and the API accepts a `Consumer<String>`. I'll consider a bit different approach where we wrap that pluggable `deleteFunc` into a `Consumer<Iterable<String>>` or similar. Let's see how that works out. I also responded to the current comments. Thanks again for taking a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
