stevenzwu commented on code in PR #12239:
URL: https://github.com/apache/iceberg/pull/12239#discussion_r1953584278
##########
open-api/rest-catalog-open-api.py:
##########
@@ -502,6 +502,9 @@ class PlanStatus(BaseModel):
class RegisterTableRequest(BaseModel):
name: str
metadata_location: str = Field(..., alias='metadata-location')
+ overwriteRequested: Optional[bool] = Field(
Review Comment:
should use underscore and hyphen for consistency. On the other hand, I think
simple `overwrite` is probably enougb
##########
open-api/rest-catalog-open-api.py:
##########
@@ -502,6 +502,9 @@ class PlanStatus(BaseModel):
class RegisterTableRequest(BaseModel):
name: str
metadata_location: str = Field(..., alias='metadata-location')
+ overwriteRequested: Optional[bool] = Field(
Review Comment:
should use underscore and hyphen for consistency. On the other hand, I think
simple `overwrite` is probably enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
