RussellSpitzer commented on code in PR #12060:
URL: https://github.com/apache/iceberg/pull/12060#discussion_r1953266565
##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -278,37 +277,41 @@ static Types.StructType fileType(Types.StructType
partitionType) {
DataFile.REFERENCED_DATA_FILE);
}
- static class IndexedManifestEntry<F extends ContentFile<F>>
- implements ManifestEntry<F>, IndexedRecord {
- private final org.apache.avro.Schema avroSchema;
+ static class ManifestEntryWrapper<F extends ContentFile<F>>
+ implements ManifestEntry<F>, StructLike {
+ private final int size;
private final Long commitSnapshotId;
- private final IndexedDataFile<?> fileWrapper;
+ private final DataFileWrapper<?> fileWrapper;
private ManifestEntry<F> wrapped = null;
- IndexedManifestEntry(Long commitSnapshotId, Types.StructType
partitionType) {
- this.avroSchema = AvroSchemaUtil.convert(entrySchema(partitionType),
"manifest_entry");
+ ManifestEntryWrapper(Long commitSnapshotId) {
+ this.size = entrySchema(Types.StructType.of()).columns().size();
Review Comment:
Same comment as above, just seems like we are doing a lot of work to get a
constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
