z1bbo commented on code in PR #12233:
URL: https://github.com/apache/iceberg/pull/12233#discussion_r1953010151


##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -387,6 +387,29 @@ public void testListNamespace() throws Exception {
         .hasMessage("Namespace does not exist: db.db2.ns2");
   }
 
+  @Test

Review Comment:
   Yes, it's tricky because it differs by JVM.
   It seems to come down to how [this URI.resolve 
call](https://github.com/apache/hadoop/blob/19bd575e32ec9ff65d58d8efcc7cf2bdb4e4b73a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java#L161)
 is interpreted by the JVM
   
   For a call like this
   ```java
   new Path("s3a://bucket").uri.resolve(new Path("ns").uri);
   ```
   the failing JVM versions return `s3a://bucketns` (the path part of `ns` 
doesn't begin with a slash)
   
   for the working JVM versions it's  `s3a://bucket/ns` (the path part of `/ns` 
does begin with a slash)
   
   I've expanded the list of tested JVMs a bit!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to