kevinjqliu commented on code in PR #1534:
URL: https://github.com/apache/iceberg-python/pull/1534#discussion_r1951735621
##########
pyiceberg/table/__init__.py:
##########
@@ -1086,6 +1094,78 @@ def name_mapping(self) -> Optional[NameMapping]:
"""Return the table's field-id NameMapping."""
return self.metadata.name_mapping()
+ def upsert(
+ self, df: pa.Table, join_cols: list[str], when_matched_update_all:
bool = True, when_not_matched_insert_all: bool = True
+ ) -> UpsertResult:
+ """Shorthand API for performing an upsert to an iceberg table.
Review Comment:
> I saw the only thing that failed in the CI was the docs build. Any idea
why and if it's something I can fix?
CI's running `make docs-build`, you can also run this locally.
```
WARNING - griffe: pyiceberg/table/__init__.py:1105: No type or annotation
for parameter 'self'
WARNING - griffe: pyiceberg/table/__init__.py:1111: Parameter 'Example'
does not appear in the function signature
Aborted with 2 warnings in strict mode!
```
we build docs in strict mode; there are issues with the current docstring as
outlined above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
