zeroshade commented on code in PR #286: URL: https://github.com/apache/iceberg-go/pull/286#discussion_r1951376224
########## utils/context.go: ########## @@ -0,0 +1,20 @@ +package utils + +import ( + "context" + + "github.com/aws/aws-sdk-go-v2/aws" +) + +type awsctxkey struct{} + +func WithAwsConfig(ctx context.Context, cfg *aws.Config) context.Context { + return context.WithValue(ctx, awsctxkey{}, cfg) +} + +func GetAwsConfig(ctx context.Context) *aws.Config { Review Comment: Last nitpick: need docstring comments please :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org