bryanck commented on PR #12224: URL: https://github.com/apache/iceberg/pull/12224#issuecomment-2651840830
> > > Canonicalization can help when field names are reused within a single metadata file, so that seemed helpful still. > > > > > > canonicalization lifecycle is scoped to a single metadata file? if it is also JVM lifecycle scope (like String intern), it can also be a problem for large tables and a server handling many tables. > > I believe it is scoped to a parser instance, and we generally create a new parser for each AFAIK. (https://github.com/fasterxml/jackson-core/wiki/JsonFactory-Features) Actually that doesn't seem correct, it is for any parser created by the same factory, so we should probably turn canonicalization off instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
