kevinjqliu commented on code in PR #1621:
URL: https://github.com/apache/iceberg-python/pull/1621#discussion_r1949597444
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1348,33 +1348,34 @@ def _task_to_record_batches(
next_index = 0
batches = fragment_scanner.to_batches()
for batch in batches:
- next_index = next_index + len(batch)
- current_index = next_index - len(batch)
- output_batches = iter([batch])
+ current_index = next_index
+ next_index = current_index + len(batch)
Review Comment:
is this logically equivalent? feels like there was a reason to write it the
other way.
cc @sungwy do you have context on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
