Fokko commented on code in PR #766:
URL: https://github.com/apache/iceberg-python/pull/766#discussion_r1948746839
##########
pyiceberg/catalog/hive.py:
##########
@@ -138,17 +141,34 @@ class _HiveClient:
_client: Client
_ugi: Optional[List[str]]
- def __init__(self, uri: str, ugi: Optional[str] = None):
- url_parts = urlparse(uri)
- transport = TSocket.TSocket(url_parts.hostname, url_parts.port)
- self._transport = TTransport.TBufferedTransport(transport)
- protocol = TBinaryProtocol.TBinaryProtocol(transport)
+ def __init__(self, uri: str, ugi: Optional[str] = None, kerberos_auth:
Optional[bool] = HIVE_KERBEROS_AUTH_DEFAULT):
+ self._uri = uri
+ self._kerberos_auth = kerberos_auth
+ self._ugi = ugi.split(":") if ugi else None
+
+ self._init_thrift_client()
+
+ def _init_thrift_client(self):
+ url_parts = urlparse(self._uri)
+
+ socket = TSocket.TSocket(url_parts.hostname, url_parts.port)
+
+ if not self._kerberos_auth:
+ self._transport = TTransport.TBufferedTransport(socket)
+ else:
+ self._transport = TTransport.TSaslClientTransport(socket,
host=url_parts.hostname, service="hive")
+
+ protocol = TBinaryProtocol.TBinaryProtocol(self._transport)
self._client = Client(protocol)
- self._ugi = ugi.split(":") if ugi else None
def __enter__(self) -> Client:
- self._transport.open()
+ if not self._kerberos_auth:
+ self._transport.open()
+ else:
+ self._init_thrift_client()
Review Comment:
I think we can remove it here, it is also called on line 149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
