kevinjqliu commented on issue #1053:
URL: 
https://github.com/apache/iceberg-python/issues/1053#issuecomment-2645885731

   Thanks for the contribution!! Appreciate it. 
   Before we close out this issue, i want to double check a few things
   1. Documentation, all tables are documented at 
https://py.iceberg.apache.org/api/#inspecting-tables
   2. Optional time travel, for any none `all_*` metadata tables, lets expose 
an optional parameter `snapshot_id` to provide the ability to time travel. This 
is already available in some metadata tables. Let's make sure its consistent 
across all metadata tables
   3. When time traveling, we should take into account the state of the table 
at the particular snapshot_id. Things like schema and partition evolution. In 
some places, we just use `tbl.metadata.schema()` which is the current table 
schema and might be incorrect when time traveling
   4. Similar to above, for `all_*` metadata tables, when querying other 
snapshots, make sure we're using the correct table state 
   
   Other than those, i think we're good to include this in the next release! 🥳 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to