swapna267 commented on code in PR #12191:
URL: https://github.com/apache/iceberg/pull/12191#discussion_r1947355037
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/SqlBase.java:
##########
@@ -86,7 +86,7 @@ protected void dropDatabase(String database, boolean
ifExists) {
sql("DROP DATABASE %s %s", ifExists ? "IF EXISTS" : "", database);
}
- protected static String toWithClause(Map<String, String> props) {
+ public static String toWithClause(Map<String, String> props) {
Review Comment:
This is currently being across Tests under org.apache.iceberg.flink. Wanted
to use for test under org.apache.iceberg.flink.source.
org.apache.iceberg.flink.source.SqlHelpers can be another option, where this
can be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
