smaheshwar-pltr commented on code in PR #1611:
URL: https://github.com/apache/iceberg-python/pull/1611#discussion_r1945618221
##########
mkdocs/docs/configuration.md:
##########
@@ -54,18 +54,19 @@ Iceberg tables support table properties to configure table
behavior.
### Write options
-| Key | Options
| Default | Description
|
-|------------------------------------------|-----------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}`
| zstd | Sets the Parquet compression coddec.
|
-| `write.parquet.compression-level` | Integer
| null | Parquet compression level for the codec. If not set, it is up to
PyIceberg
|
-| `write.parquet.row-group-limit` | Number of rows
| 1048576 | The upper bound of the number of entries within a single row group
|
-| `write.parquet.page-size-bytes` | Size in bytes
| 1MB | Set a target threshold for the approximate encoded size of data
pages within a column chunk
|
-| `write.parquet.page-row-limit` | Number of rows
| 20000 | Set a target threshold for the maximum number of rows within a
column chunk
|
-| `write.parquet.dict-size-bytes` | Size in bytes
| 2MB | Set the dictionary page size limit per row group
|
-| `write.metadata.previous-versions-max` | Integer
| 100 | The max number of previous version metadata files to keep before
deleting after commit.
|
-| `write.object-storage.enabled` | Boolean
| True | Enables the
[`ObjectStoreLocationProvider`](configuration.md#object-store-location-provider)
that adds a hash component to file paths. Note: the default value of `True`
differs from Iceberg's Java implementation |
-| `write.object-storage.partitioned-paths` | Boolean
| True | Controls whether [partition values are included in file
paths](configuration.md#partition-exclusion) when object storage is enabled
|
-| `write.py-location-provider.impl` | String of form `module.ClassName`
| null | Optional, [custom
`LocationProvider`](configuration.md#loading-a-custom-location-provider)
implementation
|
+| Key | Options
| Default | Description
|
+|------------------------------------------|------------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| `write.parquet.compression-codec` | `{uncompressed,zstd,gzip,snappy}`
| zstd | Sets the Parquet compression coddec.
|
+| `write.parquet.compression-level` | Integer
| null | Parquet compression level for the codec. If not set, it is up to
PyIceberg
|
+| `write.parquet.row-group-limit` | Number of rows
| 1048576 | The upper bound of the number of entries within a single row group
|
+| `write.parquet.page-size-bytes` | Size in bytes
| 1MB | Set a target threshold for the approximate encoded size of data
pages within a column chunk
|
+| `write.parquet.page-row-limit` | Number of rows
| 20000 | Set a target threshold for the maximum number of rows within a
column chunk
|
+| `write.parquet.dict-size-bytes` | Size in bytes
| 2MB | Set the dictionary page size limit per row group
|
+| `write.metadata.previous-versions-max` | Integer
| 100 | The max number of previous version metadata files to keep before
deleting after commit.
|
+| `write.object-storage.enabled` | Boolean
| True | Enables the
[`ObjectStoreLocationProvider`](configuration.md#object-store-location-provider)
that adds a hash component to file paths. Note: the default value of `True`
differs from Iceberg's Java implementation |
+| `write.object-storage.partitioned-paths` | Boolean
| True | Controls whether [partition values are included in file
paths](configuration.md#partition-exclusion) when object storage is enabled
|
+| `write.py-location-provider.impl` | String of form `module.ClassName`
| null | Optional, [custom
`LocationProvider`](configuration.md#loading-a-custom-location-provider)
implementation
|
+| `write.data.path` | String pointing to location
| ∅ | Sets the location where to write the data. If not set, it will
use the table location postfixed with `data/`.
|
Review Comment:
Looks great - thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
