amogh-jahagirdar commented on code in PR #12188: URL: https://github.com/apache/iceberg/pull/12188#discussion_r1945416902
########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -267,14 +267,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -This binary artifact contains Airlift Slice. - -Copyright: 2013-2020 Slice authors. -Home page: https://github.com/airlift/slice -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- Review Comment: I think removing Airlift Slice from our License is good, it's not in our JAR (which makes sense since Slice was removed as a dependency from Aircompressor a while back https://github.com/airlift/aircompressor/pull/100) . ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -469,6 +461,14 @@ License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- +This binary artifact contains Codehale Metrics. + +Copyright: (c) 2010-2013 Coda Hale, Yammer.com, 2014-2021 Dropwizard Team +Home page: https://github.com/dropwizard/metrics +License: https://www.apache.org/licenses/LICENSE-2.0.html + +-------------------------------------------------------------------------------- + Review Comment: I also agree with adding this, we do depend on these metrics `IcebergStreamWriterMetrics` does some sort of resevoir sampling which uses `SlidingWindowReservoir` from this package and i see classes from this dependency in the jar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
