amogh-jahagirdar commented on PR #12160:
URL: https://github.com/apache/iceberg/pull/12160#issuecomment-2640037643

   > I'm seeing
   > 
   > ```
   > This binary artifact contains code from Daniel Lemire's JavaFastPFOR 
project.
   > 
   > Copyright: 2013 Daniel Lemire
   > Home page: https://github.com/lemire/JavaFastPFOR
   > License: Apache License Version 2.0 
http://www.apache.org/licenses/LICENSE-2.0
   > ```
   > 
   > In the license, but I'm not able to find this in the dependency tree
   
   The Parquet License still references JavaFastPFOR 
https://github.com/apache/parquet-java/blob/parquet-1.15.x/LICENSE#L189 and I 
still see some references to the source in Parquet 
https://github.com/apache/parquet-java/blob/fb6f0be0323f5f52715b54b8c6602763d8d0128d/parquet-generator/src/main/java/org/apache/parquet/encoding/bitpacking/IntBasedBitPackingGenerator.java#L29
 . I think we'd need to keep this, until we update Parquet (based on the code 
comment it looks like that code path I referenced is no longer really used 
upstream)? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to