nastra commented on code in PR #12165: URL: https://github.com/apache/iceberg/pull/12165#discussion_r1940646018
########## api/src/test/java/org/apache/iceberg/types/TestTypes.java: ########## @@ -47,4 +49,15 @@ public void fromPrimitiveString() { .isThrownBy(() -> Types.fromPrimitiveString("abcdefghij")) .withMessage("Cannot parse type string to primitive: abcdefghij"); } + + @Test + public void testNestedFieldBuilderIdCheck() { + assertThatExceptionOfType(NullPointerException.class) + .isThrownBy(() -> optional("field").ofType(Types.StringType.get()).build()) + .withMessage("id cannot be null"); Review Comment: ```suggestion .withMessage("Id cannot be null"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org