amogh-jahagirdar commented on code in PR #12145: URL: https://github.com/apache/iceberg/pull/12145#discussion_r1939627448
########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -203,14 +203,6 @@ -------------------------------------------------------------------------------- -This binary artifact contains Apache Avro. - -Copyright: 2014-2020 The Apache Software Foundation. -Home page: https://parquet.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- - Review Comment: Why are we removing this? We still have Avro in the bundle. ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -219,22 +211,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0.txt -------------------------------------------------------------------------------- -This binary artifact contains Apache Parquet. - -Copyright: 2014-2020 The Apache Software Foundation. -Home page: https://parquet.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- - -This binary artifact contains Apache Thrift. - -Copyright: 2006-2010 The Apache Software Foundation. -Home page: https://thrift.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- Review Comment: Same as above, we still have Parquet and Thrift classes in the bundle. I don't think these should be removed. ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -464,47 +385,76 @@ License text: -------------------------------------------------------------------------------- -This binary artifact includes Project Nessie with the following in its NOTICE -file: +This binary artifact contains Project Nessie. -| Dremio -| Copyright 2015-2017 Dremio Corporation -| -| This product includes software developed at -| The Apache Software Foundation (http://www.apache.org/). +Copyright: Copyright 2015-2025 Dremio Corporation +Home page: https://projectnessie.org/ +License: http://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -This binary includes code from Apache Commons. - -* Core ArrayUtil. +This binary artifact contains failsafe. -Copyright: 2020 The Apache Software Foundation -Home page: https://commons.apache.org/ -License: https://www.apache.org/licenses/LICENSE-2.0 +Copyright: Jonathan Halterman and friends +Home page: https://failsafe.dev/ +License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This binary artifact contains Apache HttpComponents Client. +This binary artifact contains Codahale Metrics. -Copyright: 1999-2022 The Apache Software Foundation. -Home page: https://hc.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 +Copyright: Copyright (c) 2010-2013 Coda Hale, Yammer.com, 2014-2021 Dropwizard Team +Home page: https://metrics.dropwizard.io/4.2.0/ +License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This product includes code from Apache HttpComponents Client. - -* retry and error handling logic in ExponentialHttpRequestRetryStrategy.java Review Comment: I'm not sure we should be removing this? We use this in the REST client which is part of core, HttpClient ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -464,47 +385,76 @@ License text: -------------------------------------------------------------------------------- -This binary artifact includes Project Nessie with the following in its NOTICE -file: +This binary artifact contains Project Nessie. -| Dremio -| Copyright 2015-2017 Dremio Corporation -| -| This product includes software developed at -| The Apache Software Foundation (http://www.apache.org/). +Copyright: Copyright 2015-2025 Dremio Corporation +Home page: https://projectnessie.org/ +License: http://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- -This binary includes code from Apache Commons. - -* Core ArrayUtil. +This binary artifact contains failsafe. -Copyright: 2020 The Apache Software Foundation -Home page: https://commons.apache.org/ -License: https://www.apache.org/licenses/LICENSE-2.0 +Copyright: Jonathan Halterman and friends +Home page: https://failsafe.dev/ +License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This binary artifact contains Apache HttpComponents Client. +This binary artifact contains Codahale Metrics. -Copyright: 1999-2022 The Apache Software Foundation. -Home page: https://hc.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 +Copyright: Copyright (c) 2010-2013 Coda Hale, Yammer.com, 2014-2021 Dropwizard Team +Home page: https://metrics.dropwizard.io/4.2.0/ +License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This product includes code from Apache HttpComponents Client. - -* retry and error handling logic in ExponentialHttpRequestRetryStrategy.java +This binary artifact contains RoaringBitmap. -Copyright: 1999-2022 The Apache Software Foundation. -Home page: https://hc.apache.org/ -License: https://www.apache.org/licenses/LICENSE-2.0 +Copyright: (c) 2013-... the RoaringBitmap authors +Home page: https://github.com/RoaringBitmap/RoaringBitmap +License: https://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This binary artifact contains failsafe. Review Comment: It'd be a bit easier to review this if we kept dependencies which we know we are keeping in the same place. Any new things could just be added to the end and any corrections would just happen in place. ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -243,22 +219,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This binary artifact contains Apache ORC. - -Copyright: 2013-2020 The Apache Software Foundation. -Home page: https://orc.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- - -This binary artifact contains Apache Hive's storage API via ORC. - -Copyright: 2013-2020 The Apache Software Foundation. -Home page: https://hive.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - Review Comment: I think this is fine to remove, it's just some META-INF/pom.xml files that are being included. ########## flink/v1.20/flink-runtime/LICENSE: ########## @@ -243,22 +219,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0.html -------------------------------------------------------------------------------- -This binary artifact contains Apache ORC. - -Copyright: 2013-2020 The Apache Software Foundation. -Home page: https://orc.apache.org/ -License: http://www.apache.org/licenses/LICENSE-2.0 - --------------------------------------------------------------------------------- Review Comment: Same as above. We still bundle ORC so I don't think this should be removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
