nastra commented on code in PR #12148:
URL: https://github.com/apache/iceberg/pull/12148#discussion_r1938256751
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestSparkFileRewriter.java:
##########
@@ -375,6 +400,17 @@ public void testInvalidValuesForZOrderDataOptions() {
assertThatThrownBy(() ->
rewriter.init(invalidVarLengthContributionOptions))
.hasMessageContaining("Cannot use less than 1 byte for variable length
types with ZOrder")
.hasMessageContaining("'var-length-contribution' was set to 0");
+
+ Map<String, String> negativeDeleteRatioThresholdOptions =
+ ImmutableMap.of(SparkZOrderDataRewriter.DELETE_RATIO_THRESHOLD, "-1");
+ assertThatThrownBy(() ->
rewriter.init(negativeDeleteRatioThresholdOptions))
+ .hasMessageContaining("'delete-ratio-threshold' is set to negative but
must be >= 0");
+
+ Map<String, String> invalidDeleteRatioThresholdOptions =
+ ImmutableMap.of(SparkZOrderDataRewriter.DELETE_RATIO_THRESHOLD, "127");
+ ;
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
