adutra commented on code in PR #11992:
URL: https://github.com/apache/iceberg/pull/11992#discussion_r1932146669
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -206,21 +206,24 @@ private AuthSession authSession() {
return authSessionCache()
.get(
token,
- id ->
- AuthSession.fromAccessToken(
- httpClient(),
- tokenRefreshExecutor(),
- token,
- expiresAtMillis(properties()),
- new AuthSession(
- ImmutableMap.of(),
- AuthConfig.builder()
- .token(token)
- .credential(credential())
- .scope(SCOPE)
- .oauth2ServerUri(oauth2ServerUri())
- .optionalOAuthParams(optionalOAuthParams())
- .build())));
+ id -> {
+ RESTClient client =
+
httpClient().withAuthSession(org.apache.iceberg.rest.auth.AuthSession.EMPTY);
Review Comment:
Indeed. The child client is lightweight though, but it's probably better to
move this call to `httpClient()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
