aokolnychyi commented on code in PR #12100:
URL: https://github.com/apache/iceberg/pull/12100#discussion_r1929856814


##########
format/spec.md:
##########
@@ -337,8 +337,11 @@ The set of metadata columns is:
 | **`2147483546  file_path`**      | `string`      | Path of a file, used in 
position-based delete files                                                    |
 | **`2147483545  pos`**            | `long`        | Ordinal position of a 
row, used in position-based delete files                                        
 |
 | **`2147483544  row`**            | `struct<...>` | Deleted row values, used 
in position-based delete files                                                |
-| **`2147483543  _row_id`**        | `long`        | A unique long assigned 
when row-lineage is enabled, see [Row Lineage](#row-lineage)                    
|
-| **`2147483542  _last_updated_sequence_number`**   | `long`        | The 
sequence number which last updated this row when row-lineage is enabled [Row 
Lineage](#row-lineage) |
+| **`2147483543  _change_type`**                    | `string`      | Used in 
Changelog: The change type for this particular row:  INSERT, DELETE, 
UPDATE_BEFORE, or UPDATE_AFTER |

Review Comment:
   I'd probably structure these statements as:
   - `The record type in changelog (INSERT, ...)`
   - `The snapshot ID in which the change occurred`



##########
format/spec.md:
##########
@@ -337,8 +337,11 @@ The set of metadata columns is:
 | **`2147483546  file_path`**      | `string`      | Path of a file, used in 
position-based delete files                                                    |
 | **`2147483545  pos`**            | `long`        | Ordinal position of a 
row, used in position-based delete files                                        
 |
 | **`2147483544  row`**            | `struct<...>` | Deleted row values, used 
in position-based delete files                                                |
-| **`2147483543  _row_id`**        | `long`        | A unique long assigned 
when row-lineage is enabled, see [Row Lineage](#row-lineage)                    
|
-| **`2147483542  _last_updated_sequence_number`**   | `long`        | The 
sequence number which last updated this row when row-lineage is enabled [Row 
Lineage](#row-lineage) |
+| **`2147483543  _change_type`**                    | `string`      | Used in 
Changelog: The change type for this particular row:  INSERT, DELETE, 
UPDATE_BEFORE, or UPDATE_AFTER |
+| **`2147483542  _change_ordinal`**                 | `int`         | Used in 
Changelog: The order of the change                                              
                    |
+| **`2147483541  _commit_snapshot_id`**             | `long`        | Used for 
Changelog: The snapshot id in which the change occured                          
                   |

Review Comment:
   Minor: `id` -> `ID`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to