feniljain commented on code in PR #907:
URL: https://github.com/apache/iceberg-rust/pull/907#discussion_r1929524955
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -396,13 +401,45 @@ impl ParquetWriter {
impl FileWriter for ParquetWriter {
async fn write(&mut self, batch: &arrow_array::RecordBatch) ->
crate::Result<()> {
self.current_row_num += batch.num_rows();
+
+ for (col, field) in batch
+ .columns()
+ .iter()
+ .zip(self.schema.as_struct().fields().iter())
+ {
+ let dt = col.data_type();
+
+ let nan_val_cnt: u64 = match dt {
+ DataType::Float32 => {
Review Comment:
Those are nice catches, lemme implement this and re-request review, thanks!
🙇🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
