ruotianwang commented on issue #12076:
URL: https://github.com/apache/iceberg/issues/12076#issuecomment-2612767531

   @RussellSpitzer Basically this line: 
https://github.com/apache/iceberg/blob/main/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java#L380
   
   The maxCommits is not the actual total commit count but from the 
configuration, which will make failedCommits higher than expected. We could 
either get the actual total commit count or directly collect failureCommit 
count within error handling block: 
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java#L232-L234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to