rdblue commented on code in PR #11904: URL: https://github.com/apache/iceberg/pull/11904#discussion_r1927639914
########## parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java: ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data.parquet; + +import java.util.List; +import java.util.Map; +import org.apache.iceberg.Schema; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.parquet.ParquetValueReader; +import org.apache.iceberg.parquet.ParquetValueReaders; +import org.apache.iceberg.types.Types.StructType; +import org.apache.parquet.column.ColumnDescriptor; +import org.apache.parquet.schema.LogicalTypeAnnotation; +import org.apache.parquet.schema.MessageType; +import org.apache.parquet.schema.PrimitiveType; +import org.apache.parquet.schema.Type; + +public class InternalReader extends BaseParquetReaders<Record> { Review Comment: Minor: The type this returns should use `StructLike` rather than `Record`. While this will return `Record`, there is no need to require it. And like the Avro readers, we plan to extend this to be able to return custom types for specific structures. That way we can use it to produce things like `ManifestFile`. I was able to get the types working like this: ```java public class InternalReader<T extends StructLike> extends BaseParquetReaders<T> { private static final InternalReader<?> INSTANCE = new InternalReader<>(); private InternalReader() {} @SuppressWarnings("unchecked") public static <T extends StructLike> ParquetValueReader<T> create(Schema expectedSchema, MessageType fileSchema) { return (ParquetValueReader<T>) INSTANCE.createReader(expectedSchema, fileSchema); } @SuppressWarnings("unchecked") public static <T extends StructLike> ParquetValueReader<T> create( Schema expectedSchema, MessageType fileSchema, Map<Integer, ?> idToConstant) { return (ParquetValueReader<T>) INSTANCE.createReader(expectedSchema, fileSchema, idToConstant); } @Override @SuppressWarnings("unchecked") protected ParquetValueReader<T> createStructReader( List<Type> types, List<ParquetValueReader<?>> fieldReaders, StructType structType) { return (ParquetValueReader<T>) ParquetValueReaders.recordReader(types, fieldReaders, structType); } ... } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
