nastra commented on code in PR #11931:
URL: https://github.com/apache/iceberg/pull/11931#discussion_r1926969493
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -219,8 +219,10 @@ private String validateVersion(TableMetadata
tableMetadata, String versionFileNa
}
}
- Preconditions.checkNotNull(
Review Comment:
technically speaking, IAE is more specific since it tells that the user
provided invalid arguments, which in this case is the `versionFileName`. See
also my other comment in
https://github.com/apache/iceberg/pull/11931#discussion_r1922479965 on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
