dttung2905 commented on code in PR #264:
URL: https://github.com/apache/iceberg-go/pull/264#discussion_r1925730568
##########
catalog/registry_test.go:
##########
@@ -88,6 +88,76 @@ func TestCatalogRegistry(t *testing.T) {
}, catalog.GetRegisteredCatalogs())
}
+func TestRegistryPanic(t *testing.T) {
+ defer func() {
+ if r := recover(); r != nil {
+ assert.Equal(t, "catalog: RegisterCatalog catalog
factory is nil", r)
+ } else {
+ t.Fatalf("expect a panic but did not get one")
+ }
+
+ }()
+ catalog.Register("foobar", nil)
+ t.Fatalf("expect a panic but Register function did not")
Review Comment:
Thanks @zeroshade for the quick feedback, I have made the necessary changes
:pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
