huaxingao commented on code in PR #11993: URL: https://github.com/apache/iceberg/pull/11993#discussion_r1924690853
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ########## @@ -213,10 +213,13 @@ public void readFromViewUsingNonExistingTable() throws NoSuchTableException { assertThatThrownBy(() -> sql("SELECT * FROM %s", viewName)) .isInstanceOf(AnalysisException.class) - .hasMessageContaining( Review Comment: Thanks @nastra for your comment! I'm concerned that checking for specific error messages might make the tests a bit fragile. While this particular error message seems stable, others might change between versions. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org