aokolnychyi commented on code in PR #11986:
URL: https://github.com/apache/iceberg/pull/11986#discussion_r1924123333


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -214,6 +214,10 @@ private boolean fanoutWriterEnabled(boolean defaultValue) {
   }
 
   public FileFormat deleteFileFormat() {
+    if (!(table instanceof BaseMetadataTable) && 
TableUtil.formatVersion(table) >= 3) {

Review Comment:
   We may not need `table instanceof BaseMetadataTable` once we add support for 
minor DV compaction. It looks good now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to