liurenjie1024 commented on code in PR #882: URL: https://github.com/apache/iceberg-rust/pull/882#discussion_r1922964129
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -226,8 +228,10 @@ pub enum PrimitiveType { /// Timestamp in microsecond precision, with timezone Timestamptz, /// Timestamp in nanosecond precision, without timezone + #[serde(rename = "timestamp_ns")] Review Comment: I would suggest to do it in another pr with some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org