kevinjqliu commented on issue #1456: URL: https://github.com/apache/iceberg-python/issues/1456#issuecomment-2603098530
I think `TimestampLiteral(datetime_to_micros(value))` is fine. We use `TimestampLiteral(timestamp_to_micros(self.value))` to convert string to timestamp https://github.com/apache/iceberg-python/blob/b15934d5a9e6bf97b047f63239cc21ba1c15cdd4/pyiceberg/expressions/literals.py#L570-L576 cc @Fokko wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
