Fokko commented on code in PR #11679:
URL: https://github.com/apache/iceberg/pull/11679#discussion_r1919736097
##########
core/src/main/java/org/apache/iceberg/AllManifestsTable.java:
##########
@@ -292,11 +295,14 @@ static StaticDataTask.Row manifestFileToRow(
manifest.partitionSpecId(),
manifest.snapshotId(),
manifest.content() == ManifestContent.DATA ?
manifest.addedFilesCount() : 0,
+ manifest.content() == ManifestContent.DATA ? manifest.addedRowsCount()
: 0L,
manifest.content() == ManifestContent.DATA ?
manifest.existingFilesCount() : 0,
+ manifest.content() == ManifestContent.DATA ?
manifest.existingRowsCount() : 0L,
manifest.content() == ManifestContent.DATA ?
manifest.deletedFilesCount() : 0,
manifest.content() == ManifestContent.DELETES ?
manifest.addedFilesCount() : 0,
manifest.content() == ManifestContent.DELETES ?
manifest.existingFilesCount() : 0,
manifest.content() == ManifestContent.DELETES ?
manifest.deletedFilesCount() : 0,
+ manifest.content() == ManifestContent.DELETES ?
manifest.deletedRowsCount() : 0L,
Review Comment:
Is this correct? I don't think this captures copy-on-write deletes (that I
would expect to be included when seeing a column called `deleted_rows_count`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
