Fokko commented on PR #11977: URL: https://github.com/apache/iceberg/pull/11977#issuecomment-2596850981
This is looking great @bryanck, thanks for working on this 👍 How about documenting the process of checking if the NOTICE files are up to date as part of the [how-to-release](https://iceberg.apache.org/how-to-release/)? What Ryan also mentioned is that not everything in the NOTICE is required. The official [ASF docs state](https://infra.apache.org/licensing-howto.html#mod-notice): Do not add anything to `NOTICE` which is not legally required. For example, if we copy the NOTICE from Parquet-Java, the general `NOTICE` contains a section that's only [relevant for `parquet-protobuf`](https://github.com/apache/parquet-java/blob/7a99d86d579a00bbf9e29153118773485cba4fc4/NOTICE#L29C23-L29C39) that we don't use in the project. > I liked the idea that Ryan suggested this morning, where our plugin would always generate and check the generated files against a set of committed existing files and report an error if there was a change from that state. Basically a RevAPI for our license files I like that as well, we could run the `compareLicenseReport` task as part of the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
