ZENOTME opened a new pull request, #893: URL: https://github.com/apache/iceberg-rust/pull/893
This PR is intended to resolve #891. On our original design, we allow the user to create the writer builder and combine them and build them finally. However, original design is not support to change the config of builder after we combine them. But in some case, we hope to recreate the writer for different partition using writer builder. E.g. in #819, we want to regenerate the table location for different partition. So I follow the design from iceberg-java https://github.com/apache/iceberg/blob/d96901b843395fe669f6bd4f618f8e5e46c0eed4/core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java#L334 : 1. separate the OutputFile from FileWriter. 2. create a new abstract `SinglePartitionWriterBuilder`. 3. introduce the OutputFileGenerator following https://github.com/apache/iceberg/blob/d96901b843395fe669f6bd4f618f8e5e46c0eed4/core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java#L36 It's the responsibility of SinglePartitionWriterBuilder to create the OutputFile. And the build function of SinglePartitionWriterBuilder take a partition value which means that we can create different partition of writer from this Builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
