flyrain commented on code in PR #11967:
URL: https://github.com/apache/iceberg/pull/11967#discussion_r1917634187
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -561,14 +561,11 @@ public Scan buildChangelogScan() {
boolean emptyScan = false;
if (startTimestamp != null) {
- if (table.currentSnapshot() != null
- && table.currentSnapshot().timestampMillis() < startTimestamp) {
+ if (table.currentSnapshot() == null
+ || startTimestamp > table.currentSnapshot().timestampMillis()) {
emptyScan = true;
}
startSnapshotId = getStartSnapshotId(startTimestamp);
- if (startSnapshotId == null && endTimestamp == null) {
- emptyScan = true;
- }
}
if (endTimestamp != null) {
Review Comment:
Should we consider moving the following part out of the `if (endTimestamp !=
null) {}` block? It seems there’s a potential to trigger the issue described in
#8133, where the procedure fails due to null checks on the start snapshot and
end snapshot.
```
if ((startSnapshotId == null && endSnapshotId == null)
|| (startSnapshotId != null &&
startSnapshotId.equals(endSnapshotId))) {
emptyScan = true;
}
```
One scenario that might cause this is when:
- `startSnapshotId` is `null`
- `endTimestamp` is `null`
- `endSnapshotId` is `null`
This combination could bypass the intended logic and lead to the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
