manuzhang commented on PR #11340:
URL: https://github.com/apache/iceberg/pull/11340#issuecomment-2594354446

   @wypoon I plan to add metrics for all write operations, but I'd like to get 
the interfaces right at first. I'm not sure whether this is the best way to 
propagate a `metricsReporter`. Any thoughts?
   
   ```java
       if (this.table instanceof BaseTable) {
         this.metricsReporter = new InMemoryMetricsReporter();
         ((BaseTable) this.table).combineMetricsReporter(metricsReporter);
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to