lidavidm commented on code in PR #30: URL: https://github.com/apache/iceberg-cpp/pull/30#discussion_r1917497458
########## src/iceberg/io/file_io.h: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <memory> +#include <string> + +#include "iceberg/iceberg_export.h" + +namespace iceberg { +namespace io { + +class ICEBERG_EXPORT InputFile { + public: + explicit InputFile(std::string path) : path_(std::move(path)) {} + + virtual ~InputFile() = default; + + virtual bool exists() const = 0; Review Comment: Why would we have some methods on the file and some on the FileIO? ########## src/iceberg/io/fs_file_io.h: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include "file_io.h" + +namespace iceberg { +namespace io { + +class ICEBERG_EXPORT FsInputFile : public InputFile { + public: + explicit FsInputFile(std::string path) : InputFile(std::move(path)) {} + ~FsInputFile() = default; + + bool exists() const override; +}; + +class ICEBERG_EXPORT FsOutputFile : public OutputFile { + public: + explicit FsOutputFile(std::string path) : OutputFile(std::move(path)) {} + ~FsOutputFile() = default; + + void create() override; +}; + +class ICEBERG_EXPORT FsFileIO : public FileIO { + public: + FsFileIO() : FileIO("fs") {} + ~FsFileIO() = default; + + std::shared_ptr<InputFile> newInputFile(const std::string& path) override; + std::shared_ptr<OutputFile> newOutputFile(const std::string& path) override; Review Comment: are we using lowerCamelCase or UpperCamelCase for method names? (Google style would be the latter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
