Fokko commented on code in PR #11967:
URL: https://github.com/apache/iceberg/pull/11967#discussion_r1916371869
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -561,14 +561,11 @@ public Scan buildChangelogScan() {
boolean emptyScan = false;
if (startTimestamp != null) {
- if (table.currentSnapshot() != null
- && table.currentSnapshot().timestampMillis() < startTimestamp) {
+ if (table.currentSnapshot() == null
+ || table.currentSnapshot().timestampMillis() < startTimestamp) {
Review Comment:
Nit, but for me this is easier to reason. When `startTimestamp` is after the
timestamp of the current table snapshot:
```suggestion
|| startTimestamp > table.currentSnapshot().timestampMillis()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
