nastra commented on code in PR #11948:
URL: https://github.com/apache/iceberg/pull/11948#discussion_r1916260635
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -61,7 +63,9 @@ class BaseSnapshot implements Snapshot {
String operation,
Map<String, String> summary,
Integer schemaId,
- String manifestList) {
+ String manifestList,
+ Long firstRowId,
+ Long addedRows) {
Review Comment:
maybe worth adding an overriding constructor that takes these two new
arguments? And the existing constructor would then just pass nulls for these?
That way you wouldn't have to update all the constructor calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
